Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements from #2027 #2051

Merged
merged 4 commits into from
Nov 1, 2022
Merged

Minor improvements from #2027 #2051

merged 4 commits into from
Nov 1, 2022

Conversation

olupton
Copy link
Collaborator

@olupton olupton commented Nov 1, 2022

Changes that could easily be extracted from #2027.

  • Tell clang-format how to interpret PyObject_HEAD
  • Drop isoc99.{h,cpp} and nrn_isdouble function
  • Update submodule to include Allow Custom build type iv#45 so one can build with -DCMAKE_BUILD_TYPE=Custom and -DNRN_ENABLE_INTERVIEWS=ON.
  • Add missing include in src/ivoc/ocnotify.h
  • Drop a lot of unused code in cxprop.cpp -- note that the 6th line of nrn_cache_prop_realloc was a return statement, and has been for some time.

@azure-pipelines
Copy link

✔️ 735935d -> Azure artifacts URL

@olupton
Copy link
Collaborator Author

olupton commented Nov 1, 2022

@olupton olupton requested review from nrnhines and alkino November 1, 2022 15:31
@olupton
Copy link
Collaborator Author

olupton commented Nov 1, 2022

@olupton olupton marked this pull request as ready for review November 1, 2022 16:12
@olupton olupton merged commit 53f87a1 into master Nov 1, 2022
@olupton olupton deleted the olupton/bits-and-bobs branch November 1, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants