Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callbacks for reading mapping information from memory #2555

Merged
merged 31 commits into from
Mar 13, 2024
Merged

Callbacks for reading mapping information from memory #2555

merged 31 commits into from
Mar 13, 2024

Conversation

WeinaJi
Copy link
Collaborator

@WeinaJi WeinaJi commented Sep 28, 2023 •
edited
Loading

neurodamus branch https://github.com/BlueBrain/neurodamus/tree/weji/direct_mod
to launch coreneuron simulation with in memory mode.

@azure-pipelines
Copy link

✔️ 3d6b9e5 -> Azure artifacts URL

@codecov
Copy link

codecov bot commented Sep 28, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.09524% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 67.14%. Comparing base (e3e8625) to head (a3b93c2).

Files Patch % Lines
src/coreneuron/io/phase3.cpp 86.11% 5 Missing ⚠️
src/coreneuron/io/core2nrn_data_return.cpp 0.00% 2 Missing ⚠️
src/nrniv/nrncore_write/io/nrncore_io.cpp 88.23% 2 Missing ⚠️
src/coreneuron/io/nrn_filehandler.hpp 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2555      +/-   ##
==========================================
+ Coverage   66.92%   67.14%   +0.22%     
==========================================
  Files         560      561       +1     
  Lines      104091   104145      +54     
==========================================
+ Hits        69658    69932     +274     
+ Misses      34433    34213     -220

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines
Copy link

✔️ 96276d0 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@WeinaJi WeinaJi force-pushed the weji/directmode_dat3 branch from 96276d0 to 2de5b7a Compare November 6, 2023 07:49
@bbpbuildbot

This comment has been minimized.

Sign in to view
@WeinaJi WeinaJi force-pushed the weji/directmode_dat3 branch from 2de5b7a to c906088 Compare December 4, 2023 07:56
@azure-pipelines Azure Pipelines
Copy link

✔️ c906088 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ d9cba6b -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@WeinaJi WeinaJi force-pushed the weji/directmode_dat3 branch from d9cba6b to 86f969e Compare December 8, 2023 20:13
@azure-pipelines Azure Pipelines
Copy link

✔️ 86f969e -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ 1b0a9a8 -> Azure artifacts URL

@azure-pipelines Azure Pipelines
Copy link

✔️ c54bf23 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@WeinaJi WeinaJi marked this pull request as ready for review December 13, 2023 08:47
@WeinaJi WeinaJi changed the title Callbacks for reading mapping info for in memory mode Callbacks for reading mapping information from memory Dec 13, 2023
@jorblancoa
Copy link
Contributor

Looks good!! Thanks!
Just one extra comment, is it possible to create some unit tests? At least for the nrncore_callbacks (nrnthread_dat3_cell_count, nrnthread_dat3_cellmapping, etc.) I guess for read_phase3() would be a bit more complicated...although i did something similar for LFP populating the cellmapping, mapinfo etc

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ cdce92c -> Azure artifacts URL

@WeinaJi WeinaJi force-pushed the weji/directmode_dat3 branch from cdce92c to 3057bbd Compare January 12, 2024 14:19
@azure-pipelines Azure Pipelines
Copy link

✔️ 3057bbd -> Azure artifacts URL

@azure-pipelines Azure Pipelines
Copy link

✔️ c6de08b -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@WeinaJi WeinaJi force-pushed the weji/directmode_dat3 branch from c6de08b to 83d8304 Compare March 11, 2024 10:08
@azure-pipelines Azure Pipelines
Copy link

✔️ 83d8304 -> Azure artifacts URL

@WeinaJi WeinaJi mentioned this pull request Mar 11, 2024
Merged
@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ c699a54 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ 75793e8 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@bbpbuildbot

This comment has been minimized.

Sign in to view
pramodk
pramodk reviewed Mar 11, 2024
View reviewed changes
Copy link
Member

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! I have a few minor comments to cross-check.

src/coreneuron/io/nrn_filehandler.hpp Show resolved Hide resolved
test/external/ringtest/CMakeLists.txt Outdated Show resolved Hide resolved
src/coreneuron/io/phase3.cpp Show resolved Hide resolved
@azure-pipelines Azure Pipelines
Copy link

✔️ b9b7bf7 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@WeinaJi WeinaJi force-pushed the weji/directmode_dat3 branch from b9b7bf7 to a3b93c2 Compare March 12, 2024 15:32
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
19 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@azure-pipelines Azure Pipelines
Copy link

✔️ a3b93c2 -> Azure artifacts URL

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #200014 (:no_entry:) have been uploaded here!

Status and direct links:

pramodk
pramodk approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for @WeinaJi !! 🚀

@pramodk pramodk merged commit 17be061 into master Mar 13, 2024
37 checks passed
@pramodk pramodk deleted the weji/directmode_dat3 branch March 13, 2024 20:08
1uc added a commit that referenced this pull request Mar 22, 2024
@1uc
Revert "Callbacks for reading mapping information from memory (#2555)"
c2bda00 
This reverts commit 17be061.
1uc added a commit that referenced this pull request Mar 22, 2024
@1uc
Revert "Callbacks for reading mapping information from memory (#2555)"
607519b 
This reverts commit 17be061.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorblancoa jorblancoa jorblancoa approved these changes

@pramodk pramodk pramodk approved these changes

@iomaganaris iomaganaris Awaiting requested review from iomaganaris

Assignees
No one assigned
Labels
hackron2023
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WeinaJi @bbpbuildbot @jorblancoa @pramodk @ohm314