Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always install external headers. #2972

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

matz-e
Copy link
Collaborator

@matz-e matz-e commented Jul 10, 2024

Prepares for NEURON + NMODL, where we will need to provide at the
minimum Eigen.

Fixes #2970.

Prepares for NEURON + NMODL, where we will need to provide at the
minimum Eigen.

Fixes #2970.
Copy link

Copy link

✔️ 5fa294f -> Azure artifacts URL

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.25%. Comparing base (ce50582) to head (5fa294f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2972      +/-   ##
==========================================
- Coverage   67.26%   67.25%   -0.01%     
==========================================
  Files         572      572              
  Lines      104895   104896       +1     
==========================================
- Hits        70555    70553       -2     
- Misses      34340    34343       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@1uc 1uc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this seems to fix the issue.

@1uc 1uc merged commit 1f1f8c9 into master Jul 10, 2024
38 checks passed
@1uc 1uc deleted the always-install-external-headers branch July 10, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NEURON + NMODL build failure: can't find Eigen.
4 participants