Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Move CBMA methods up a level #283

Merged
merged 4 commits into from
Jul 12, 2020
Merged

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Jul 12, 2020

Closes #220.

Changes proposed in this pull request:

  • Remove the CBMA submodule to simplify the organization of the package.
  • Add warning about likelihood-based estimators to associated docstrings.

tsalo added 3 commits July 12, 2020 14:09
This removes the CBMA submodule to simplify the organization of the
package.
@codecov
Copy link

codecov bot commented Jul 12, 2020

Codecov Report

Merging #283 into master will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
- Coverage   74.49%   74.46%   -0.04%     
==========================================
  Files          39       38       -1     
  Lines        3717     3712       -5     
==========================================
- Hits         2769     2764       -5     
  Misses        948      948              
Impacted Files Coverage Δ
nimare/base.py 66.85% <ø> (ø)
nimare/correct.py 91.02% <ø> (ø)
nimare/meta/ibma.py 98.59% <ø> (ø)
nimare/meta/peaks2maps.py 1.75% <ø> (ø)
nimare/decode/continuous.py 65.21% <100.00%> (ø)
nimare/meta/__init__.py 100.00% <100.00%> (ø)
nimare/meta/ale.py 93.24% <100.00%> (ø)
nimare/meta/kernel.py 79.87% <100.00%> (ø)
nimare/meta/mkda.py 92.36% <100.00%> (ø)
nimare/meta/utils.py 57.14% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 729d701...f48a914. Read the comment docs.

@tsalo tsalo merged commit d7025af into neurostuff:master Jul 12, 2020
@tsalo tsalo deleted the ref/move-cbma branch July 12, 2020 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interlinking in documentation is inconsistent
1 participant