Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add test steps and explicit support for Python 3.9 #578

Merged
merged 5 commits into from
Oct 18, 2021

Conversation

JulioAPeraza
Copy link
Collaborator

@JulioAPeraza JulioAPeraza commented Oct 8, 2021

Closes #575.

Changes proposed in this pull request:

  • Support Python version 3.9. Create and add a new job for 3.9 in the CircleCI config file.

@JulioAPeraza JulioAPeraza changed the title [WIP,ENH] Add test steps and explicit support for Python 3.9 and 3.10 [ENH] Add test steps and explicit support for Python 3.9 and 3.10 Oct 8, 2021
@JulioAPeraza JulioAPeraza marked this pull request as ready for review October 8, 2021 20:18
@JulioAPeraza JulioAPeraza requested a review from tsalo October 8, 2021 20:18
@tsalo
Copy link
Member

tsalo commented Oct 11, 2021

There seems to be a problem installing NiMARE in 3.9 and 3.10. Is it possible that our minimum version of setuptools in pyproject.toml needs to be bumped up?

@JulioAPeraza
Copy link
Collaborator Author

Updating the version fixed the issue. Should we use the latest release (setuptools==58.2.0)?

@tsalo
Copy link
Member

tsalo commented Oct 11, 2021

If it still works for Python 3.6, then yes. Otherwise, I'd like to determine the most recent version that works for all Python versions we support.

@JulioAPeraza
Copy link
Collaborator Author

It seems like numpy has not released a wheel for Python 3.10.

@tsalo
Copy link
Member

tsalo commented Oct 11, 2021

Darn... it seems like we'll have to wait until they release it. Would you rather add 3.9 support in this PR and tackle 3.10 later, or just wait to merge this?

@JulioAPeraza
Copy link
Collaborator Author

I would add 3.9 support in this PR and tackle 3.10 later. The numpy wheel may be out by next month, but any issues with a different package in 3.10 may delay the 3.9 support.

@tsalo
Copy link
Member

tsalo commented Oct 12, 2021

That works for me.

@tsalo
Copy link
Member

tsalo commented Oct 18, 2021

Can you do two things:

  1. Change all instances of deps9 to deps10 in the CircleCI config file? That will create a new cache, which should have the fixed version of flake8-isort.
  2. Rename the PR and update the summary to make it clear that 3.10 isn't being added.

@JulioAPeraza JulioAPeraza changed the title [ENH] Add test steps and explicit support for Python 3.9 and 3.10 [ENH] Add test steps and explicit support for Python 3.9 Oct 18, 2021
@tsalo
Copy link
Member

tsalo commented Oct 18, 2021

Thanks! 🤞 Here's hoping CI passes without issue.

EDIT: And if it does I'll approve and merge.

@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #578 (da49d80) into main (e8814c2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #578   +/-   ##
=======================================
  Coverage   85.82%   85.82%           
=======================================
  Files          39       39           
  Lines        4267     4267           
=======================================
  Hits         3662     3662           
  Misses        605      605           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8814c2...da49d80. Read the comment docs.

Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tsalo tsalo merged commit 05bbd89 into neurostuff:main Oct 18, 2021
@tsalo tsalo added maintenance Issues/PRs related to maintenance/infrastructure. testing Improving testing in the project labels Nov 6, 2021
@JulioAPeraza JulioAPeraza deleted the enh-pyversions branch June 2, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issues/PRs related to maintenance/infrastructure. testing Improving testing in the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test steps and explicit support for Python 3.9
2 participants