-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement cluster mass-based cluster-level Monte Carlo correction for CBMA algorithms #609
Conversation
RTD is failing due to a problem with m2r and mistune. |
Codecov Report
@@ Coverage Diff @@
## main #609 +/- ##
==========================================
+ Coverage 85.85% 85.91% +0.06%
==========================================
Files 40 40
Lines 4382 4401 +19
==========================================
+ Hits 3762 3781 +19
Misses 620 620
Continue to review full report at Codecov.
|
Renaming the existing cluster size-based maps counts as a breaking change. |
The results look the same as cluster size for an example Dataset with 17 studies and FWE correction with 10000 iterations. Also, the cluster size and mass null distributions were correlated at about 0.9, and the cluster mass and max ALE value distributions were correlated at about 0.91. I think I can conclude that the results are what we'd expect. |
Closes #608.
Changes proposed in this pull request:
<z|logp>_desc-mass_level-cluster_corr-FWE_method-montecarlo
maps.<z|logp>_level-cluster_corr-FWE_method-montecarlo
maps to<z|logp>_desc-size_level-cluster_corr-FWE_method-montecarlo
.To do: