Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve memory management in MKDAChi2 Estimator #638

Merged
merged 5 commits into from
Feb 14, 2022

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Feb 12, 2022

Closes None. The changes in this PR are small, but should reduce memory usage somewhat.

Changes proposed in this pull request:

  • Reorder steps in the MKDAChi2 fit process to delete large arrays as soon as we are done with them.

@tsalo tsalo added cbma Issues/PRs pertaining to coordinate-based meta-analysis refactoring Requesting changes to the code which do not impact behavior labels Feb 12, 2022
@codecov
Copy link

codecov bot commented Feb 13, 2022

Codecov Report

Merging #638 (5e9e8b8) into main (86eda1c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #638      +/-   ##
==========================================
+ Coverage   87.89%   87.91%   +0.01%     
==========================================
  Files          40       40              
  Lines        4337     4343       +6     
==========================================
+ Hits         3812     3818       +6     
  Misses        525      525              
Impacted Files Coverage Δ
nimare/meta/cbma/mkda.py 96.40% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86eda1c...5e9e8b8. Read the comment docs.

@tsalo tsalo merged commit 69be3e3 into neurostuff:main Feb 14, 2022
@tsalo tsalo deleted the mkdachi2-improvements branch February 14, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cbma Issues/PRs pertaining to coordinate-based meta-analysis refactoring Requesting changes to the code which do not impact behavior
Projects
Development

Successfully merging this pull request may close these issues.

1 participant