Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch testing from CircleCI to GitHub Actions #642

Merged
merged 13 commits into from
Feb 18, 2022
Merged

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Feb 16, 2022

Closes None.

Changes proposed in this pull request:

  • Replace the CircleCI configuration with a new GitHub workflow.

To do:

  • Merge coverage reports before uploading to CodeCov.
  • Move the linter into a separate workflow?

@tsalo tsalo added the testing Improving testing in the project label Feb 16, 2022
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #642 (c4d78ea) into main (2060739) will increase coverage by 0.22%.
The diff coverage is 100.00%.

❗ Current head c4d78ea differs from pull request most recent head 171949b. Consider uploading reports for the commit 171949b to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #642      +/-   ##
==========================================
+ Coverage   84.78%   85.00%   +0.22%     
==========================================
  Files          40       40              
  Lines        4343     4381      +38     
==========================================
+ Hits         3682     3724      +42     
+ Misses        661      657       -4     
Impacted Files Coverage Δ
nimare/meta/cbma/ale.py 95.02% <100.00%> (+2.27%) ⬆️
nimare/meta/cbma/mkda.py 96.41% <0.00%> (+0.01%) ⬆️
nimare/meta/cbma/base.py 94.71% <0.00%> (+0.02%) ⬆️
nimare/utils.py 95.46% <0.00%> (+0.05%) ⬆️
nimare/transforms.py 75.45% <0.00%> (+0.08%) ⬆️
nimare/base.py 88.39% <0.00%> (+0.21%) ⬆️
nimare/correct.py 92.47% <0.00%> (+0.42%) ⬆️
nimare/dataset.py 89.72% <0.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f71e0f...171949b. Read the comment docs.

@tsalo
Copy link
Member Author

tsalo commented Feb 17, 2022

I need to figure out how to merge the coverage reports from each of the individual jobs.

@tsalo tsalo added the maintenance Issues/PRs related to maintenance/infrastructure. label Feb 18, 2022
@tsalo tsalo merged commit b6c25a0 into neurostuff:main Feb 18, 2022
@tsalo tsalo deleted the github-ci branch February 18, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issues/PRs related to maintenance/infrastructure. testing Improving testing in the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant