Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace relative imports with absolute ones #674

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Apr 26, 2022

Closes None. Absolute imports are recommended by PEP8, and I think this will make it easier to identify any circular import problems as we start reorganizing base classes.

@tsalo tsalo added the refactoring Requesting changes to the code which do not impact behavior label Apr 26, 2022
@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #674 (0d97212) into main (b806510) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #674   +/-   ##
=======================================
  Coverage   85.28%   85.28%           
=======================================
  Files          40       40           
  Lines        4513     4513           
=======================================
  Hits         3849     3849           
  Misses        664      664           
Impacted Files Coverage Δ
nimare/annotate/cogat.py 91.35% <100.00%> (ø)
nimare/annotate/gclda.py 97.35% <100.00%> (ø)
nimare/annotate/text.py 90.32% <100.00%> (ø)
nimare/base.py 88.49% <100.00%> (ø)
nimare/correct.py 93.06% <100.00%> (ø)
nimare/dataset.py 89.72% <100.00%> (ø)
nimare/decode/continuous.py 94.73% <100.00%> (ø)
nimare/decode/discrete.py 96.61% <100.00%> (ø)
nimare/decode/encode.py 85.18% <100.00%> (ø)
nimare/extract/extract.py 42.97% <100.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b806510...0d97212. Read the comment docs.

@tsalo
Copy link
Member Author

tsalo commented Apr 28, 2022

@jdkent @adelavega @JulioAPeraza do any of you have any issues with me merging this?

Copy link
Member

@jdkent jdkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I do not think any of the import statements are overly verbose written out explicitly
relevant PEP8 section

@adelavega
Copy link
Member

Fine w/ me

@JulioAPeraza
Copy link
Collaborator

Fine with me too.

@tsalo tsalo merged commit 6cd751e into neurostuff:main Apr 28, 2022
@tsalo tsalo deleted the absolute-imports branch April 28, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Requesting changes to the code which do not impact behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants