Optimize locating coordinates in convert_neurosynth_to_dataset

[ryanhammonds]

Closes #666.

Changes proposed in this pull request:

• small optimization that reduces convert_neurosynth_to_dataset runtime from ~7min to ~3min.
• I profiled these changes with:

from nimare.extract import fetch_neurosynth
from nimare.io import convert_neurosynth_to_dataset

neurosynth_db = fetch_neurosynth(
    data_dir='.',
    version="7",
    source="abstract",
    vocab="terms",
)[0]

neurosynth_dset = convert_neurosynth_to_dataset(
    coordinates_file=neurosynth_db["coordinates"],
    metadata_file=neurosynth_db["metadata"],
    annotations_files=neurosynth_db["features"],
    feature_groups=['alzheimer']
)

[welcome]

Thanks for opening this pull request! We have detected this is the first time you have contributed to NiMARE. Please check out our contributing guidelines.
We invite you to list yourself as a NiMARE contributor, so if your name is not already mentioned, please modify the .zenodo.json file with your data right above Angie's entry. Example:

{
  "name": "Contributor, New",
  "affiliation": "Department of Psychology, Some University",
  "orcid": "<your id>"
},
{
  "name": "Laird, Angela R.",
  "affiliation": "Florida International University",
  "orcid": "0000-0003-3379-8744"
},

Of course, if you want to opt out this time there is no problem at all with adding your name later. You will be always welcome to add it in the future whenever you feel it should be listed.

[codecov]

Codecov Report

Merging #682 (a767254) into main (ceaebc3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #682   +/-   ##
=======================================
  Coverage   85.24%   85.25%           
=======================================
  Files          41       41           
  Lines        4479     4482    +3     
=======================================
+ Hits         3818     3821    +3     
  Misses        661      661           

Impacted Files	Coverage Δ
nimare/io.py	95.14% <100.00%> (+0.07%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ceaebc3...a767254. Read the comment docs.

[tsalo]

@ryanhammonds Thank you for the contribution! It looks like the linter is complaining, though. Can you run black on your code?

[tsalo]

These changes look good to me, and I was able to reproduce the profiling results locally. @adelavega, since you opened the original issue, I wanted to see if this is what you were thinking of before merging.

[tsalo]

Also, @ryanhammonds, do you want to add yourself to the Zenodo file?

[ryanhammonds]

Thanks @tsalo! No need to add me to the Zenodo file. Maybe if I make larger contributions in the future.

[adelavega]

Nice. LGTM. I'm a bit surprised how much of a difference using numpy instead of pandas makes. Good lesson for other parts of the package.

[tsalo]

Great, thanks @adelavega!

Merging now. Thanks again for the contribution @ryanhammonds.