Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results objects break if user called fit() rather than fit_dataset() #52

Closed
tyarkoni opened this issue Oct 13, 2020 · 1 comment · Fixed by #104
Closed

Results objects break if user called fit() rather than fit_dataset() #52

tyarkoni opened this issue Oct 13, 2020 · 1 comment · Fixed by #104
Labels
bug Something isn't working

Comments

@tyarkoni
Copy link
Contributor

tyarkoni commented Oct 13, 2020

The various results classes all currently require access to the estimator's last-fitted Dataset, which won't exist now following the API change to allow fit() to be called with numpy arrays. The solution is to either implicitly create and store a Dataset, which would be easier, but feels counterproductive (since the point of eliminating Dataset inputs from fit() was to cut down overhead), or to directly store references to the input arrays rather than to a Dataset in the estimator (in which case we have to add a bunch of code to every estimator, and lose some of the benefits of the `Dataset abstraction).

@tsalo
Copy link
Member

tsalo commented Oct 13, 2020

Based on local testing with NiMARE, I think this is specific to the CombinationTest classes.

EDIT: Sorry, I jumped the gun there. The issue was that the CombinationTest classes behaved confusingly with Datasets, so I used fit() for them and fit_dataset() for the other Estimators. Just ignore my comment...

@tyarkoni tyarkoni added the bug Something isn't working label Oct 13, 2020
@tsalo tsalo pinned this issue Jan 9, 2022
@tsalo tsalo closed this as completed in #104 Jun 5, 2022
@tsalo tsalo unpinned this issue Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants