Allow Results objects to work with Estimators' fit() method #104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #52.
Changes proposed:
.dataset_
attribute with None when callingfit()
.fit_dataset()
will then replace that with the actual Dataset if it is called. Otherwise,.dataset_
will remain None..dataset
) fromEstimator.dataset_
.Result.dataset
is None before using it. When it is None, raise a ValueError.fit
is okay or if you needfit_dataset
.fit
-generated Results' methods can be used and when you need afit_dataset
-generated Result.