Incorrect and inconsistent resource names

[lindhe]

I've noticed that the resources have no clear naming convention. This both looks messy and is somewhat misleading. This takes two different forms: incorrect names, inconsistent names and missing (or redundant) names.

Incorrect name suffix

Many non-pod resources has -pod in their names, for example:

neuvector-helm/charts/core/templates/updater-cronjob.yaml

Line 11 in 0d0faff

name: neuvector-updater-pod

neuvector-helm/charts/core/templates/scanner-deployment.yaml

Line 9 in 0d0faff

name: neuvector-scanner-pod

neuvector-helm/charts/core/templates/enforcer-daemonset.yaml

Line 9 in 0d0faff

name: neuvector-enforcer-pod

neuvector-helm/charts/monitor/templates/secret.yaml

Line 5 in 0d0faff

name: neuvector-prometheus-exporter-pod-secret

Inconsistent names

Sometimes the short name is used and sometimes the long name:

neuvector-helm/charts/core/templates/controller-service.yaml

Line 5 in 0d0faff

name: neuvector-svc-controller

neuvector-helm/charts/core/templates/manager-service.yaml

Line 5 in 0d0faff

name: neuvector-service-webui

Being consistent is pretty important, so one can easily grep for names when debugging.

Missing (or redundant) name suffix

Many resources do not have the resource kind as part of their names, for example:

neuvector-helm/charts/core/templates/serviceaccount-least.yaml

Line 5 in 0d0faff

name: basic

neuvector-helm/charts/core/templates/rolebinding.yaml

Line 14 in 0d0faff

name: neuvector-admin

neuvector-helm/charts/core/templates/pvc.yaml

Line 6 in 0d0faff

name: neuvector-data

neuvector-helm/charts/core/templates/clusterrolebinding-least.yaml

Line 14 in 0d0faff

name: neuvector-binding-app

This, however, may not be an actual issue. Why have the resource type in the name at all? It's not necessary, since the type is almost always clear from context. I would argue we should drop the resource kind from the names altogether, since it is evidently hard to maintain this naming scheme consistently for all resources.

But the important point here is that we should be consistent.