feat: add support for monitor chart securityContext and labels #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Additional context, there are forks of this chart that implement these features for hardened environments but it would be nice for the community at large to benefit from some of these options: https://repo1.dso.mil/big-bang/product/packages/neuvector Excited to see this potentially get in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain environments may use different images for the exporter which require a different run as user/group (i.e. a hardened image which is based on a different base image). There are also environments where certain security contexts may be enforced (i.e. no running as root, all capabilities must be dropped, etc). In these cases it is beneficial to expose the securityContext (and containerSecurityContext).
It's also generally nice to expose pod labels.