Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] add s3 config screen #30

Merged
merged 3 commits into from
Sep 26, 2022
Merged

[Draft] add s3 config screen #30

merged 3 commits into from
Sep 26, 2022

Conversation

newhinton
Copy link
Owner

Closes #8

@newhinton newhinton changed the title add s3 config screen [WIP] add s3 config screen Aug 30, 2022
@newhinton newhinton changed the title [WIP] add s3 config screen [Draft] add s3 config screen Aug 30, 2022
@newhinton newhinton self-assigned this Aug 30, 2022
@newhinton
Copy link
Owner Author

newhinton commented Sep 3, 2022

extRact_v2.0.3-dev_20220903_0436-oss-arm64-v8a-debug.zip

This is a current apk with the s3 provider.

@chymian I have added the more generic settings for this provider, which allowed me to connect fully via the ui. If more settings are needed to be exposed, please add them here as a comment!

@chymian
Copy link

chymian commented Sep 5, 2022

I tested the apk. and here are some observations:

  1. without knowing whether it makes a difference within the executed code, the selected s3-provider is on linux what one selects, like Minio, Backblaze, etc.
    whitin extract rclone.conf its always
provider = S3 service provider

they might have different handling of s3, since there are differences in the protocol-implementation out there! at least it could make a difference in the displayed icon (see 5.)

  1. I forgot the portnumber on my first entry and it was queryeing endless, no timeout.
  2. there is no edit config button.
  3. I couldn't figure out how to sync or copy a local dir to a remote or vice versa. only Download, Move, Rename & Delete are available options.
  4. and a usabillity tidbit: having an amazon icon for all S3 providers, is the same as having a daimler-star on all cars today, because he was the first one to build/invente the cars. ;)
    maybe just grab and display the favicon makes it more clearer, if one has more than one buckets/providers configured (https://s3.domain.tld:9001/favicon-32x32.png)

felix, thanks for all your work

@newhinton
Copy link
Owner Author

newhinton commented Sep 5, 2022

Thanks for your evaluation!

  1. This is a bug. I probably know where i went wrong and fix it.
  2. This may or may not be "expected". I will investigate!
  3. This is currently expected, feel free to open a feature request for that!
  4. I will check that
  5. You are probably right, is there a dedicated S3 logo? Otherwise i will just whip something up that is not branded.

I really like the favicon-idea! Though i will probably make it opt-in. Also i will have to redo the whole config-classes, this might take a bit.

Edit:
Is .../favicon_32x32.png really the favicon path? usually its only favicon.ico

@chymian
Copy link

chymian commented Sep 7, 2022

Is .../favicon_32x32.png really the favicon path? usually its only favicon.ico

your right with favicon.ico should be the default.
my proposal was just quick-check (in browser-dev mode) with my minio.

  1. …is there a dedicated S3 logo?

AFAIK, only the amazon s3-logo, https://en.wikipedia.org/wiki/Amazon_S3

@newhinton
Copy link
Owner Author

Are you sure about 1? I cannot reproduce it. However, i added a check for it anyway.

About 4: If you mean the threedot-menu when using the file explorer, sync&copy are not supported in this manner. Uploading works with using the plus-floating action button in the bottom-right. If you want to sync or copy, you can add a task for that since that allows you to specify the target-directory.

@newhinton
Copy link
Owner Author

About 2: This was fixed, until i figured out that it broke rclone completely. Currently the timeouts are like 30 seconds, and with 10 retries it takes a while. There is a timeout though!

I need to figure out the proper flags that would reduce the "rigtht" timeouts, because there are multiple ones, and some break long-running tasks like calculating md5 checksums after transfer for big files.

@chymian
Copy link

chymian commented Sep 26, 2022

Are you sure about 1? I cannot reproduce it. However, i added a check for it anyway.

you are right. I assume it was my mistake on my sec. try.
the provider-menu point was just out of sight/overlapped by the keyboard and I most likely oversaw it.
good that you made that check, so it cannot happen again.

About 4: If you mean the threedot-menu when using the file explorer, sync&copy are not supported in this manner.

I was selecting a file/dir, and the yellow action-bar at the bottom pop up.

Uploading works with using the plus-floating action button in the bottom-right.

ok, I see. which is not very obvious, when you select a file/folder & see the yellow bar…
one can download, etc… but not upload

If you want to sync or copy, you can add a task for that since that allows you to specify the target-directory.

true, and makes a lot of sence for repitive jobs. I was more talking about a manual or one-time shot. ;)

@newhinton
Copy link
Owner Author

I was selecting a file/dir, and the yellow action-bar at the bottom pop up.

true, and makes a lot of sence for repitive jobs. I was more talking about a manual or one-time shot. ;)

Ah okay i know what you mean. You wanted to copy a file from your device (sdcard or internal storage) to a remote, right?
As far as i know, there is no picker for that, this is not the "expected" usecase. But i agree, it can be confusing. I am not sure if i want to change this behaviour, but regardless of that, it would be a different issue ticket anyway.

The usual way of doing this would be to find the target folder on the remote, and then upload the local file via the plus button. The nextcloud app does it the same way, though they dont have a way to manage local storage.

@newhinton newhinton merged commit f644c1b into master Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remotes: Implement S3-Buckets as RemoteConfig
2 participants