[Feature] Dynamic Config Provider #82

newhinton · 2023-04-03T11:05:42Z

closes #63
closes #86
closes #101

Signed-off-by: Felix Nüsse <[email protected]>

newhinton · 2023-04-27T09:56:04Z

@gilbsgilbs If you want to take a look at this PR, i have now switched a lot of remotes to the new dynamic way. Though there are a lot of missing features and rough edges, so it is not recommended to install it on an actual device.

gilbsgilbs · 2023-04-27T09:58:04Z

Ack. I'm very busy right now, but I'll try to take a look at a non-deterministic point in time.

gilbsgilbs

IIUC, this adds support for "generic" providers, but at the moment, you cannot add them all from the UI. The list is limited to the providers declared in the provider_ids array. However, they should still be usable thanks to the import feature, is that correct?

Overall I think it is a fantastic and very useful work. The implementation is rather concise and reads better than I anticipated. Here are some general remarks (I'm sure you're aware of most of them as this is still a WIP):

I had a build error (related to de translations), but removing those values worked around it. Rebasing master and bringing back CI workflows should make that apparent.
As you said here, the amount of configuration per provider is indeed kind of overwhelming. I think this could be very much improved by putting "advanced" options in a separate tab or in a collapsible menu. But another PR for this is fine I think.
As noted in a comment in your code, dark mode is not supported yet.
The dropdown options are very small. It's easy to missclick if you have fat fingers.

Regarding translations, my experiments with deepl.com have been fairly impressive, and I've yet to find an completely incorrect translation. With some pre/post-processing, it could be a decent starting point before relying on the community. Their API free-tier allows 500k characters/month. There's currently ~130k characters to translate.

app/src/main/java/ca/pkay/rcloneexplorer/RemoteConfig/extensions/Hubic.kt

app/src/main/java/ca/pkay/rcloneexplorer/RemoteConfig/ConfigExtension.kt

app/src/main/java/ca/pkay/rcloneexplorer/Rclone.java

gilbsgilbs · 2023-04-29T09:17:20Z

app/src/main/java/ca/pkay/rcloneexplorer/RemoteConfig/DynamicConfig.kt

+        input.setPadding(padding)
+        val items = ArrayList<String>()
+
+        option.examples.forEach { example ->


It's smart to use examples for dropdowns, however, I'm unsure this covers all the cases. RClone still allows specifying arbitrary values for options with "Examples". For instance, s3 backend has many endpoint options with examples, but may you roll out your own S3-compatible storage such as Minio, in which case you'll always want to specify a custom endpoint. Still, it's unclear to me if specifying arbitrary values for those is actually useful in practice ⬇️

"Examples" (resp. "Options") sometimes include a Provider field, which defines a syntax allowing to restrain an example (resp. an option) to a specific set of providers. Let's take the same s3/Minio/endpoint as an example:

The backend is s3

This backend has a provider option, with Minio as one of the examples, therefore the dropdown for this option will include Minio (this is already implemented by this PR)

Then there are multiple endpoint options declared by RClone:

one with "Provider": "AWS" with specific endpoints examples for AWS

one with "Provider": "ChinaMobile" with specific endpoints examples for ChinaMobile

… so on with other providers …

one with "Provider": "!AWS,IBMCOS,…,ChinaMobile,…" (i.e. not any providers that was previously defined), which doesn't provide any example

So with our Minio example, we're in the latter case. If "providers filtering" was implemented, it would just display a text field and not a dropdown in this case, because the only endpoint option that matches our Minio provider has no examples. So it would be fine. If I'm not mistaken, with the current implementation, it will just display many endpoint dropdowns and one endpoint text input, and I'm not sure what's the behavior when passing this to RClone.

All in all, there might be niche use-cases where specifying arbitrary values for options with examples might be useful (such as using a new S3 region/endpoint for a given provider that is not implemented in RClone yet). But IDK, it might just not be worth thinking about it for the moment. However, I do reckon providers filtering should be implemented at some point.

This is exactly the kind of stuff where i wil slip with this, because i cannot extensively test every remote.

Thanks for the writeup, i will have to read this thoroughly to make this work properly, especially to prevent weird behaviour with rclone

gilbsgilbs · 2023-04-29T09:41:19Z

app/src/main/java/ca/pkay/rcloneexplorer/RemoteConfig/DynamicConfig.kt

+            Log.e("TAG", "      Opt: ${it.name}")
+            Log.e("TAG", "      Opt: ${it.type}")
+            when (it.type) {
+                "string" -> {


So, just for the sake of completeness, here are the types where the UI could be improved by using dedicated components:

bool, which should be a checkbox (there's also one boolean type, but I think it's a bug in RClone)

int, which could include some type validation

SizeSuffix, which could be implemented by specifying a textbox + a "scale" dropdown, and validating that an integer was typed in the textbox

Duration/Time, ditto or, optionally, a clock

RFC 3339, with a clock+calendar popup

MultiEncoder, which could be a multi-select box (but this one is probably niche-enough that we shouldn't bother)

SpaceSepList, which could be multiple text-fields with ➕ and 🚮 icons (also kinda niche)

Time/unixtime/decimal number/Tristate/hexadecimal/octal, unix style/filename not widely used

But that's probably fine as this in a first implementation.

there is some wild stuff in there :D I guess i start with the obvious ones, bool and string are implemented, and i most certainly will implement int aswell. The other-ones will probably have to default to text input, the user has to figure out what input needs to be made :D

app/src/main/java/ca/pkay/rcloneexplorer/RemoteConfig/RemoteConfig.java

newhinton · 2023-04-30T10:02:02Z

but at the moment, you cannot add them all from the UI

Yes. At the moment those are hardcoded, but in the future i want to try to get rid of that aswell, so that everything is "dynamic".

"advanced" options in a separate tab or in

Good idea!

Regarding translations, my experiments with deepl.com have been fairly impressive, and I've yet to find an completely incorrect translation. With some pre/post-processing, it could be a decent starting point before relying on the community. Their API free-tier allows 500k characters/month. There's currently ~130k characters to translate.

I am a bit on the fence with this idea. Generally i want to refrain from implementing a solution specific to this app, and i also would need to figure out if i am even allowed to use it. (I might want to monetize this app on the play store, so i need to be careful.)

My dream-goal would be for the rclone project to implement translations natively, and then we dont have to deal with that twice. I already opened a ticket for that, but i am afraid that will take quite a while. But generally speaking, translations in this app are going to be complicated to pull off properly.

newhinton · 2023-04-30T10:15:03Z

So let me say thank you! I did not expect such an in depth review, and i am glad you are looking at it! There is lots of great suggestions and i will implement much of it, so that this will make this app easier to maintain and use in the future.
Thank you!

Signed-off-by: Felix Nüsse <[email protected]>

# Conflicts: # app/src/main/res/layout/config_form_template_text_field.xml # app/src/main/res/layout/config_form_union.xml # app/src/main/res/layout/remote_config_form.xml # app/src/main/res/values-de/strings.xml # app/src/main/res/values/arrays.xml # app/src/main/res/values/strings.xml

Signed-off-by: Felix Nüsse <[email protected]>

newhinton · 2023-06-20T18:01:45Z

Good news! The dynamic config editor will allow rudimentary editing of remotes! Though i will need to test this thouroughly, especially if values are secret. They break if not reentered at the moment.

Signed-off-by: Felix Nüsse <[email protected]>

# Conflicts: # app/src/main/res/values/strings.xml

… performance

…json

newhinton added 4 commits February 24, 2023 21:22

Start JSON-COnfigurations

b5162a3

Signed-off-by: Felix Nüsse <[email protected]>

start implementing dynamic ui

cca10d1

Signed-off-by: Felix Nüsse <[email protected]>

switch to 'rclone config providers'

d53842f

build dynamic ui from provider

fb05f4c

Signed-off-by: Felix Nüsse <[email protected]>

newhinton mentioned this pull request Apr 7, 2023

Delete files from bin on sync (Drive) #61

Closed

3 tasks

newhinton changed the title ~~Feature/noid/configjson~~ [Feature] Dynamic Config Provider Apr 20, 2023

newhinton added this to the 2.2 Provider Update milestone Apr 20, 2023

newhinton added 6 commits April 26, 2023 15:07

build dynamic ui from provider

d0e8c0e

Signed-off-by: Felix Nüsse <[email protected]>

fix margins

4747bc0

Signed-off-by: Felix Nüsse <[email protected]>

update constraints

9bd10e4

Signed-off-by: Felix Nüsse <[email protected]>

Simplify Remotes List

104446d

Signed-off-by: Felix Nüsse <[email protected]>

remove translations to fix offset-issues in german #86

cc33a9e

Signed-off-by: Felix Nüsse <[email protected]>

Migrate Setup to DynamicConfig for majority of remotes

00066e6

Signed-off-by: Felix Nüsse <[email protected]>

gilbsgilbs reviewed Apr 29, 2023

View reviewed changes

newhinton added 10 commits May 19, 2023 20:26

Remove HUBIC due to deprecation and shutdown

7b95734

Signed-off-by: Felix Nüsse <[email protected]>

remove ambiguity from Rclone.java

3083c6c

Signed-off-by: Felix Nüsse <[email protected]>

Remove OAuth-Configs

3243160

Signed-off-by: Felix Nüsse <[email protected]>

Rename .java to .kt

a06e598

Signed-off-by: Felix Nüsse <[email protected]>

Make the provider-list dynamic too

153a4d5

Signed-off-by: Felix Nüsse <[email protected]>

Add special capitalization

d9fbf95

Signed-off-by: Felix Nüsse <[email protected]>

create checkbox view

41b1c77

Signed-off-by: Felix Nüsse <[email protected]>

remove layouts

0dea848

Signed-off-by: Felix Nüsse <[email protected]>

use proper case for options

4aa4faa

Signed-off-by: Felix Nüsse <[email protected]>

properly close fragment (with deprecated function. Good Luck!)

2b4dc49

Signed-off-by: Felix Nüsse <[email protected]>

newhinton mentioned this pull request May 28, 2023

Add support for Base32768 encoding in crypt backend #101

Closed

3 tasks

Hide advanced options behind toggle

d05df58

Signed-off-by: Felix Nüsse <[email protected]>

newhinton added 5 commits May 29, 2023 15:40

remove xml after merge

3f53432

Signed-off-by: Felix Nüsse <[email protected]>

fix theme on dynamic configurator

2d3a7ac

Signed-off-by: Felix Nüsse <[email protected]>

use mYou-theme on dynamic configurator

b5daa68

Signed-off-by: Felix Nüsse <[email protected]>

remove logging

d5e560e

Signed-off-by: Felix Nüsse <[email protected]>

newhinton mentioned this pull request Jun 14, 2023

Enable no-check-certificate or free-form rclone options #109

Open

2 tasks

Efreak mentioned this pull request Jun 15, 2023

FR private key support #111

Open

allow editing of remotes

3a8f9e0

Signed-off-by: Felix Nüsse <[email protected]>

dont input passwords from options since they are obfuscated

cdaf31c

Signed-off-by: Felix Nüsse <[email protected]>

newhinton mentioned this pull request Jul 24, 2023

OneDrive stuck at waiting for code #116

Closed

newhinton added 2 commits August 9, 2023 16:49

Merge branch 'master' into feature/noid/configjson

9d778bf

# Conflicts: # app/src/main/res/values/strings.xml

check if keys are available before using them

b09a67c

newhinton mentioned this pull request Aug 18, 2023

Unable to find correct options to connect to NextCloud via WebDav #129

Closed

newhinton added 12 commits August 19, 2023 22:40

implement int and sizesuffix

b606998

rclone: cache provider on disk to not start an rclone process

3c9aadb

remote config list - use proper recycler view to circumvent slow list…

0e51c05

… performance

fix back button behaviour

56cbb94

Rename .java to .kt

1aa1d0e

refactor RemoteConfig to kotlin

a254ce6

improve navigation flow

b395639

Merge remote-tracking branch 'origin/master' into feature/noid/config…

316d2c0

…json

add baseline from current master(b8b169a)

9950124

fix new lint issues

a3def46

Make whole row clickable

65c36ee

finalize suffix dropdown

297f42b

newhinton merged commit 297f42b into master Aug 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature] Dynamic Config Provider #82

[Feature] Dynamic Config Provider #82

newhinton commented Apr 3, 2023 •

edited

Loading

newhinton commented Apr 27, 2023

gilbsgilbs commented Apr 27, 2023

gilbsgilbs left a comment •

edited

Loading

gilbsgilbs Apr 29, 2023 •

edited

Loading

newhinton Apr 30, 2023

gilbsgilbs Apr 29, 2023

newhinton May 19, 2023

newhinton commented Apr 30, 2023

newhinton commented Apr 30, 2023

newhinton commented Jun 20, 2023

[Feature] Dynamic Config Provider #82

[Feature] Dynamic Config Provider #82

Conversation

newhinton commented Apr 3, 2023 • edited Loading

newhinton commented Apr 27, 2023

gilbsgilbs commented Apr 27, 2023

gilbsgilbs left a comment • edited Loading

Choose a reason for hiding this comment

gilbsgilbs Apr 29, 2023 • edited Loading

Choose a reason for hiding this comment

newhinton Apr 30, 2023

Choose a reason for hiding this comment

gilbsgilbs Apr 29, 2023

Choose a reason for hiding this comment

newhinton May 19, 2023

Choose a reason for hiding this comment

newhinton commented Apr 30, 2023

newhinton commented Apr 30, 2023

newhinton commented Jun 20, 2023

newhinton commented Apr 3, 2023 •

edited

Loading

gilbsgilbs left a comment •

edited

Loading

gilbsgilbs Apr 29, 2023 •

edited

Loading