QR Code JWT Integration #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholemnl
force-pushed
the
feature/jwt-integration
branch
from
00b6d60 to
3a1e92a
Compare
- Add option to show guide for scanning - Fix bug issue in scanning MRZ - Fix and add new UI for guide scanning - Add a buondingBoxDraw for debugging mlkit
- Improve scanning with mrz by fixing the setResolution to 640x480 - Clean up unnecessary code - Move essential code to bitmapUtils - Add validations to avoid crash in using MrzAnalyzer - Fix handle api for showing guide bounding box
haklyray
approved these changes
Jan 13, 2023
| val timeRequired = System.currentTimeMillis() - start | ||
| Log.d( | ||
| "${SmartScannerActivity.TAG}/SmartScanner", | ||
| "MRZ MLKit TextRecognition: success: $timeRequired ms" | ||
| ) | ||
| var rawFullRead = "" | ||
| val blocks = visionText.textBlocks | ||
|
|
||
| // val boxes = ArrayList<MRZBox>() |
There was a problem hiding this comment.
should these comments be deleted instead?
There was a problem hiding this comment.
Ahhh sorry, these will remain here for the meantime for the future debugging of MRZ.. Still getting feedback from other projects, so might be handy to have these here.
Will remove this once we have resolved the issue or improve the debugging condition here soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes /issues/127
Fixes /issues/81