Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Custom Entity Type RMP Kiosk Entity #1891

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

JimHagan
Copy link

@JimHagan JimHagan commented Jan 31, 2025

Relevant information

This is built off Log data representing various events related to custom device types. In this initial commit we are only focusing on the CSO or "Kiosk" device type.

Example ID: "UK00001CSO21"

Where:

country = "UK"
store.number = "00001"
device.type = "CSO"
device.number = "21"

In general these are 1:1 related with a host but we do not define the relationship yet. The golden singles are some log counts with various facets.

Checklist

  • I've read the guidelines and understand the acceptance criteria.
  • The value of the attribute marked as identifier will be unique and valid.
  • I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.

Copy link

@entityBot entityBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

* Error PARSING domainType: 'ext-rmp-kiosk' on entitydefinitionemitter.models.BaseEntityDefinition - jackson.databind.exc.MismatchedInputException: Missing required creator property 'name' (index 0)
at [Source: (StringReader); line: 15, column: 3] (through reference chain: entitydefinitionemitter.models.BaseEntityDefinition["synthesis"]->entitydefinitionemitter.models.CustomEntitySynthesisRules["rules"]->ArrayList[0]->entitydefinitionsclientsynthesis.models.definitions.EntitySynthesisRule["name"])

github-actions[bot]
github-actions bot previously approved these changes Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants