Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load MessageFormat in Premain #1760

Closed
kanderson250 opened this issue Feb 23, 2024 · 2 comments · Fixed by #1763
Closed

Load MessageFormat in Premain #1760

kanderson250 opened this issue Feb 23, 2024 · 2 comments · Fixed by #1763
Assignees
@jtduffy
Labels
1 Story Point Estimate GTSE There is an associated support escalation with this issue.

Comments

@kanderson250
Copy link
Contributor

To prevent a ClassCircularityError, the MessageFormat class is loaded explicitly in agentMain. However since this is in main rather than premain, this only prevents the error on agent startup via dynamic attach.

We want to add the same logic to premain. There is already a class in place to handle this exact situation, InitProblemClasses. Put something in there for MessageFormat.
@workato-integration
Copy link

https://new-relic.atlassian.net/browse/NR-232442

@jtduffy jtduffy self-assigned this Feb 26, 2024
@jtduffy jtduffy moved this from Triage to In Quarter in Java Engineering Board Feb 26, 2024
@kanderson250 kanderson250 moved this from In Quarter to In Sprint in Java Engineering Board Feb 26, 2024
@kford-newrelic kford-newrelic added the estimate Issue needing estimation label Feb 26, 2024
@kanderson250
Copy link
Contributor Author

Related GTSE: https://new-relic.atlassian.net/browse/NR-231222

@kford-newrelic kford-newrelic added the GTSE There is an associated support escalation with this issue. label Feb 26, 2024
@jtduffy jtduffy moved this from In Sprint to Needs Review in Java Engineering Board Feb 27, 2024
@jtduffy jtduffy moved this from Needs Review to In Sprint in Java Engineering Board Feb 27, 2024
@jtduffy jtduffy mentioned this issue Feb 27, 2024
Merged
@kford-newrelic kford-newrelic added 1 Story Point Estimate apr-jun qtr Represents proposed work item for the Apr-Jun quarter and removed estimate Issue needing estimation apr-jun qtr Represents proposed work item for the Apr-Jun quarter labels Feb 27, 2024
@jtduffy jtduffy moved this from In Sprint to Needs Review in Java Engineering Board Feb 27, 2024
@github-project-automation github-project-automation bot moved this from Needs Review to Code Complete/Done in Java Engineering Board Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jtduffy jtduffy

Labels
1 Story Point Estimate GTSE There is an associated support escalation with this issue.
Projects
Java Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add MessageFormat class to InitProblemClasses newrelic/newrelic-java-agent
3 participants
@jtduffy @kford-newrelic @kanderson250