Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MessageFormat class to InitProblemClasses #1763

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

jtduffy
Copy link
Contributor

@jtduffy jtduffy commented Feb 27, 2024

Resolves #1760

Load MessageFormat class early to prevent ClassCircularityError exceptions.

@jtduffy jtduffy requested a review from a team February 27, 2024 13:02
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.83%. Comparing base (ae03a7c) to head (c0f1fbe).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1763      +/-   ##
============================================
+ Coverage     70.82%   70.83%   +0.01%     
- Complexity     9929     9933       +4     
============================================
  Files           825      825              
  Lines         39823    39823              
  Branches       6035     6035              
============================================
+ Hits          28203    28208       +5     
+ Misses         8891     8888       -3     
+ Partials       2729     2727       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtduffy jtduffy merged commit c495abc into main Feb 27, 2024
103 checks passed
@jtduffy jtduffy deleted the msgformat-premain-load branch February 27, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Load MessageFormat in Premain
3 participants