Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetty12 core server transactions #1950

Merged
merged 5 commits into from
Jun 17, 2024
Merged

Conversation

jbedell-newrelic
Copy link
Contributor

Start transactions inside the core Jetty server (rather than just servlets).

@jbedell-newrelic jbedell-newrelic requested a review from a team June 14, 2024 13:33
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.66%. Comparing base (5dcd0a8) to head (99e7120).
Report is 426 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1950      +/-   ##
============================================
- Coverage     70.66%   70.66%   -0.01%     
+ Complexity     9858     9857       -1     
============================================
  Files           826      826              
  Lines         39804    39792      -12     
  Branches       6062     6061       -1     
============================================
- Hits          28127    28118       -9     
+ Misses         8951     8948       -3     
  Partials       2726     2726              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@obenkenobi obenkenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This did not break async transaction tests, good work!

@jbedell-newrelic jbedell-newrelic merged commit aae1b1b into main Jun 17, 2024
111 checks passed
@jbedell-newrelic jbedell-newrelic deleted the jetty12-core-server-txns branch June 17, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Start Jetty 12 web transactions in the core server's handle function
4 participants