Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue where the Kinesis instrumentation is generating ERROR logs due to a NullPointerException #2052

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

obenkenobi
Copy link
Contributor

@obenkenobi obenkenobi commented Sep 16, 2024

Overview

Fixes an issue where ERROR logs were generated by the Kinesis instrumentation due to a NullPointerException.

2024-09-16T13:37:08,315-0400 [10984 66] com.newrelic ERROR: An error occurred recording external metrics for class putRecord : java.lang.NullPointerException: Cannot invoke "Object.getClass()" because "value" is null

@obenkenobi obenkenobi changed the title Add null check to avoid warn logs from NullPointerException Fix an issue where the Kinesis instrumentation is generating ERROR logs due to a NullPointerException Sep 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.58%. Comparing base (857433f) to head (bbb433f).

Files with missing lines Patch % Lines
...java/com/newrelic/agent/tracers/DefaultTracer.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2052   +/-   ##
=========================================
  Coverage     70.57%   70.58%           
- Complexity     9873     9877    +4     
=========================================
  Files           829      829           
  Lines         39945    39947    +2     
  Branches       6078     6079    +1     
=========================================
+ Hits          28192    28197    +5     
  Misses         9021     9021           
+ Partials       2732     2729    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@obenkenobi obenkenobi merged commit b3669bc into main Sep 19, 2024
111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants