Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null guard for dtTracer in httpurlconnection MetricState #2086

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

obenkenobi
Copy link
Contributor

Overview

Continuation of the previous PR to replace TracedMethod instances with weak references in HttpUrlConnection. This just adds an additional null guard.

Related Github Issue

#2048

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.70%. Comparing base (eb28f6c) to head (4291fea).
Report is 61 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2086      +/-   ##
============================================
+ Coverage     70.58%   70.70%   +0.12%     
- Complexity     9878     9981     +103     
============================================
  Files           829      841      +12     
  Lines         39960    40289     +329     
  Branches       6081     6107      +26     
============================================
+ Hits          28205    28487     +282     
- Misses         9022     9055      +33     
- Partials       2733     2747      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@obenkenobi obenkenobi merged commit d9aee60 into main Nov 5, 2024
111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants