Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow JFR queue size and harvest interval to be configured via agent config #2168

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

jtduffy
Copy link
Contributor

@jtduffy jtduffy commented Dec 12, 2024

Resolves #1511

This is a continuation of @meiao 's PR to:

  • Configure JFR queue size via jfr.queue_size - default of 250000
  • Configure JFR harvest interval via jrf.harvest_interval - default of 10 seconds
  • Send up supportability metrics with the configured JFR queue size and interval values

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.69%. Comparing base (925da72) to head (ce22102).

Files with missing lines Patch % Lines
.../java/com/newrelic/agent/config/JfrConfigImpl.java 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2168      +/-   ##
============================================
- Coverage     70.71%   70.69%   -0.03%     
+ Complexity    10001     9999       -2     
============================================
  Files           842      842              
  Lines         40348    40356       +8     
  Branches       6115     6115              
============================================
- Hits          28534    28528       -6     
- Misses         9063     9075      +12     
- Partials       2751     2753       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtduffy jtduffy merged commit bbad1ef into main Dec 13, 2024
114 checks passed
@jtduffy jtduffy deleted the jfr-daemon-config branch December 13, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add configuration options to the Java APM Agent to control JFR Events Queue Size.
3 participants