-
Notifications
You must be signed in to change notification settings - Fork 27
Instrumentation broken in [email protected] #120
Comments
test: pin versioned tests to < 13.3.1 until #120 is fixed
Jira CommentId: 188489 If we do NEWRELIC-8278 this would be done. We can use this as an actual test case to confirm. |
Hey there, would #124 also cover Next's app directory? |
@kdembowski it will not. Can you please file a separate feature request for this please? It sounds like you want to file two. One for some log forwarding capabilities and something around "works with pages directory". Also, when you file those feature requests please provided as much context/example as possible so we can properly evaluate it. |
@bizob2828 I created #126. |
…ests test: pin versioned tests to < 13.3.1 until newrelic#120 is fixed
Description
In the 13.3.1 release of Next.js, our instrumentation is failing to fully register due to a change in the Next.js' webpack output. Specifically, the render and context modules are now output without setter functions, which means we're unable to apply our monkeypatch.
Expected Behavior
Versioned tests run successfully on 13.3.1
Steps to Reproduce
npm run verisoned:major
Cannot set property renderToHTML of #<Object> which has only a getter
andCannot set property getModuleContext of #<Object> which has only a getter
Additional context
Next.js@12 Context output
![Screenshot 2023-04-24 at 2 04 08 PM](https://user-images.githubusercontent.com/3333180/234079536-40b45038-21e2-4605-a5de-a91ebea59d4b.png)
[email protected] Context output
![Screenshot 2023-04-24 at 2 04 43 PM](https://user-images.githubusercontent.com/3333180/234079546-8cf686f8-14ea-465d-be6b-c95ea31ee568.png)
The text was updated successfully, but these errors were encountered: