Bugfix: Record code level metric attributes for private methods #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check private methods as well as instance methods when recording code level metric attributes when using add_method_tracer
SimpleCov Report
|
tannalynn
commented
Nov 4, 2022
| @@ -106,7 +106,7 @@ def namespace_and_location(object, method_name) | |||
| klass = object.singleton_class? ? klassify_singleton(object) : object | |||
| name = klass.name || '(Anonymous)' | |||
| is_class_method = false | |||
| method = if klass.instance_methods.include?(method_name) | |||
| method = if (klass.instance_methods + klass.private_instance_methods).include?(method_name) | |||
There was a problem hiding this comment.
I ran some microbenchmarking on different ways to combine arrays, and + was the fastest one, but not by much, all but one said same-ish: difference falls within error
fallwith
approved these changes
Nov 8, 2022
|
Hi, I am receiving a similar warning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before contributing, please read our contributing guidelines and code of conduct.
Overview
This resolves the error caused by setting add_method_tracer on a private method. Previously, the agent would fail to check the private method as an instance method because it was not included in the instance_methods array, so it attempted to record it as a class method, resulting in the following error in the logs
resolves #1589 Thanks @jdelStrother for the suggested fix!
Submitter Checklist:
Testing
The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
GitHub Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.
Reviewer Checklist