Enable defer_rails_initialization config by environment variable only #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configs are loaded during initialization. This fix was placed behind a feature flag referencing the config value, but that value will always be falsey at initialization, so the bugfix was unreachable. This change will always use the new, split initialization process.
…-agent-initialization
…tialization' of github.com:newrelic/newrelic-ruby-agent into bugfix/rails-frameworks-forced-to-load-during-agent-initialization
kaylareopelle
force-pushed
the
bugfix/rails-frameworks-forced-to-load-during-agent-initialization
branch
from
8b75702 to
1ea36e4
Compare
|
Opened on this branch by mistake |
kaylareopelle
deleted the
bugfix/rails-frameworks-forced-to-load-during-agent-initialization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Configs are loaded during initialization. This fix was placed behind a feature flag referencing the config value, but that value will always be false at initialization, so the bug fix was unreachable.
Environment variables are accessible before initialization. The environment variable
NEW_RELIC_DEFER_RAILS_INITIALIZATIONmay be set to true to enable this option.TODO:
Resolves: #662