-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set custom log attributes using newrelic.yml or environment variables #2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method transforms strings with the format "key1=value1,key2=value2" into hashes: {'key1' => 'value1', 'key2' => 'value2'}
kaylareopelle
commented
Jun 16, 2023
|
||
Thanks to [@rajpawar02](https://github.com/rajpawar02) for raising this issue and [@askreet](https://github.com/askreet) for helping us with the solution. [Issue#1141](https://github.com/newrelic/newrelic-ruby-agent/issues/1141), [PR#2084](https://github.com/newrelic/newrelic-ruby-agent/pull/2084) | ||
|
||
- **Feature: Instrument transmit_subscription_* Action Cable actions** | ||
- **Feature: Instrument transmit_subscription-related Action Cable actions** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting for this one appeared strangely due to the *
in the title.
kaylareopelle
requested review from
fallwith,
hannahramadan and
tannalynn
as code owners
June 16, 2023 21:46
SimpleCov Report
|
fallwith
reviewed
Jun 16, 2023
Co-authored-by: James Bunch <[email protected]>
fallwith
previously approved these changes
Jun 16, 2023
kaylareopelle
commented
Jun 16, 2023
fallwith
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds the ability to set custom log attributes using the configuration option
application_logging.forwarding.custom_attributes
. When submitted usingnewrelic.yml
, the value must be a hash. When submitted using an environment variable, the format must be "key1=value1,key2=value2".Attributes will be added to all log events.
Relates to: #1141