Bugfix: Dynamodb instrumentation access_key_id error on some credential classes #2684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fallwith
reviewed
Jun 3, 2024
tannalynn
commented
Jun 3, 2024
lib/new_relic/agent/instrumentation/dynamodb/instrumentation.rb
Outdated
Show resolved
Hide resolved
tannalynn
commented
Jun 3, 2024
| def get_arn(params) | ||
| return unless params[:table_name] | ||
| return unless params[:table_name] && nr_account_id |
There was a problem hiding this comment.
table name though could change every time the client makes a call jsyk
Co-authored-by: Kayla Reopelle (she/her) <[email protected]>
SimpleCov Report
|
kaylareopelle
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all aws credentials are credentials, but they do all seem to include credentials, so I've updated it to do credentials.credentials instead, which should work. I also added more safety/checks so that it won't cause an error and will just simply not try to make an arn if it doesn't have access to the necessary info.