Use media_type instead of content_type when avaliable
#2855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahramadan
changed the title
media_type instead of content_type when avaliable
fallwith
reviewed
Sep 23, 2024
CHANGELOG.md
Outdated
| @@ -56,6 +56,10 @@ Version <dev> adds Apache Kafka instrumentation for the rdkafka and ruby-kafka g | |||
|
|
|||
| [PR#2851](https://github.com/newrelic/newrelic-ruby-agent/pull/2851) | |||
|
|
|||
| - **Feature: Collect just MIME type from AcionDispatch requests** | |||
There was a problem hiding this comment.
Maybe at a byline to the summary for this version as well.
There was a problem hiding this comment.
Looking for version in title? 60dcfc9
| @@ -24,7 +24,7 @@ def initialize(request) | |||
| @referer = referer_from_request(request) | |||
| @accept = attribute_from_env(request, HTTP_ACCEPT_HEADER_KEY) | |||
| @content_length = content_length_from_request(request) | |||
| @content_type = attribute_from_request(request, :content_type) | |||
| @content_type = content_type_attribute_from_request(request) | |||
There was a problem hiding this comment.
Optionally, you could simply leverage the existing attribute_from_method's functionality instead of creating a special one-off method for content-type.
Suggested change
| @content_type = content_type_attribute_from_request(request) | |
| @content_type = content_type_attribute_from_request(request) | |
| @content_type = attribute_from_request(request, :media_type) || attribute_from_request(request, :content_type) |
There was a problem hiding this comment.
While I love the simplicity of just using one method, I liked having that longer comment + link explaining the change and it looked a bit off here.
hannahramadan
requested review from
kaylareopelle and
tannalynn
as code owners
SimpleCov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 7.0 changed the behavior of
ActionDispatch::Request#content_type, adding extra request-related details the agent wasn't expecting to collect, such as charset. Additionally, the agent's use ofcontent_typewas triggering deprecation warnings. This PR updated the agent to useActionDispatch::Request#media_typeto capture the MIME type when available.Closes #2506