Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not attempt to decorate nil logs #2986

Merged
merged 4 commits into from
Dec 7, 2024
Merged

Do not attempt to decorate nil logs #2986

merged 4 commits into from
Dec 7, 2024

Conversation

hannahramadan
Copy link
Contributor

@hannahramadan hannahramadan commented Dec 6, 2024 •
edited
Loading

We should guard against attempting to decorate nil logs.

closes #2985

@hannahramadan hannahramadan marked this pull request as ready for review December 6, 2024 20:15
kaylareopelle
kaylareopelle reviewed Dec 6, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

SimpleCov Report

Coverage Threshold
Line 93.87% 93%
Branch 69.75% 50%

@hannahramadan hannahramadan merged commit 645492b into dev Dec 7, 2024
34 checks passed
@hannahramadan hannahramadan mentioned this pull request Dec 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaylareopelle kaylareopelle kaylareopelle approved these changes

@tannalynn tannalynn Awaiting requested review from tannalynn tannalynn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log decoration throws an exception when message is nil
2 participants
@hannahramadan @kaylareopelle