Unexpected "throw" in http_external.js

[jfred]

The "hard" throw of an error in http_external.js causes a process to crash unexpectedly for me in certain heroku startups. Should this be avoided.

Example stack:

2013-08-20T01:53:54.372252+00:00 app[web.2]: error: Caught exception:  __NR_CAUGHT=true
2013-08-20T01:53:54.373548+00:00 app[web.2]: error: Error: External request metrics need to be associated with a host. Not measuring.
2013-08-20T01:53:54.373548+00:00 app[web.2]:   at recordExternal (/app/node_modules/newrelic/lib/metrics/recorders/http_external.js:9:11)
2013-08-20T01:53:54.373548+00:00 app[web.2]:   at Object.wrappedRequest (/app/node_modules/newrelic/lib/instrumentation/core/http.js:117:26)
2013-08-20T01:53:54.373548+00:00 app[web.2]:   at Object.b (domain.js:183:18)
2013-08-20T01:53:54.373548+00:00 app[web.2]:   at Object.<anonymous> (/app/node_modules/newrelic/node_modules/continuation-local-storage-glue/node_modules/continuation-local-storage/context.js:54:21)
2013-08-20T01:53:54.373548+00:00 app[web.2]:   at /app/node_modules/newrelic/lib/transaction/tracer.js:181:22
2013-08-20T01:53:54.373548+00:00 app[web.2]:   at ErrorTracer.monitor (/app/node_modules/newrelic/lib/error.js:146:12)
2013-08-20T01:53:54.373548+00:00 app[web.2]:   at Tracer.monitor (/app/node_modules/newrelic/lib/transaction/tracer.js:179:28)
2013-08-20T01:53:54.373548+00:00 app[web.2]:   at Object.wrapSegmentInvocation [as request] (/app/node_modules/newrelic/lib/transaction/tracer.js:133:17)
2013-08-20T01:53:54.373548+00:00 app[web.2]:   at Client.request (/app/node_modules/knox/lib/client.js:310:42)
2013-08-20T01:53:54.373720+00:00 app[web.2]:   at Client.get (/app/node_modules/knox/lib/client.js:585:15)
2013-08-20T01:53:54.373720+00:00 app[web.2]:   at Client.getFile (/app/node_modules/knox/lib/client.js:604:18)

[othiym23]

Yep, this is a real throw from the guts of the agent. Thanks for the report and the stacktrace! What version of knox are you running, and are you just using it to connect to standard S3?

I'll put together a patch and close this issue as when I've put out a new release.

[jfred]

Knox 0.8.6 and standard S3 - Thanks

[othiym23]

Just for future reference, that commit was made to a private repository, but the same commit has now been pushed to this repository as 558ab04. Be sure and let me know if this doesn't address your problem!