Incompatibility with raven-node

[gotvitch]

This error is throw when I use newrelic and raven-node TypeError: Cannot read property 'accept-encoding' of undefined.

There is already a similar issue #86 but I'm not sure if it's also because raven-node is used.

raven-node use raw-stacktrace to have a detailed stack trace with this code :

traces.on("trace", function(err, callsites) {
    err.structuredStackTrace = callsites;
});

And this create a problem in bunyan module line 685 :

str = JSON.stringify(obj, safeCycles()) + '\n';

It can no longer serialize errors because it can not serialize structuredStackTrace property set by raven-node.

Here a sample of code to produce the bug :

var newrelic = require('newrelic');
    raven = require('raven'),
    express = require('express'),
    app = express(),
    ravenClient = new raven.Client();

app.get('/error', function(req, res){
  throw new Error();
});

app.listen(3000);

And the package.json

{
  "dependencies": {
    "express": "~3.4.7",
    "newrelic": "~1.1.1",
    "raven": "~0.6.0"
  }
}

Run and go to http://localhost:3000/error

[othiym23]

I'm not sure this is New Relic's bug, because bunyan is the piece that's crashing and raven is the thing stashing the array of CallSites on the side of the Error. We can't work around all the crazy monkeypatching that goes on in Node modules, but we do do a lot of (probably excessively) clever stuff ourselves, so I'll take a look at how difficult it would be to harden against this kind of weirdness.

Your test case will be super helpful, so thanks for the clear description and sample code!

[adrianpike]

This cropped up from a google search - we're seeing similar things from Raven when you send it circular references. We're not using node-newrelic either. :)

[gotvitch]

Fixed with the last version of raven-node