Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to ignore error codes and urls #98

Closed
rodrigok opened this issue Dec 24, 2013 · 15 comments
Closed

Impossible to ignore error codes and urls #98

rodrigok opened this issue Dec 24, 2013 · 15 comments
Labels

Comments

@rodrigok
Copy link

I can't set my application to ignore error codes like 403 and 401, and urls like /ping. I am setting all config using env variables:

export NEW_RELIC_IGNORING_RULES=/ping
export NEW_RELIC_ERROR_COLLECTOR_IGNORE_ERROR_CODES=401,403,404

I am still receiving reports of /ping and errors of codes 401 and 403.

@brunkle
Copy link

brunkle commented Dec 26, 2013

Hi @rodrigok,
Sorry you are having problems with the agent!

I am under the impression that you are running the 1.1.1 version of the Node.js agent - can you confirm this is true? We actually pushed some updates in the latest 1.2.0 version that include bug fixes where we were not properly heeding your ignore errors settings. Those errors thrown during the execution of Express routes or Connect middlewares that were attached to requests that ended in HTTP status codes configured to be ignored by default should now be ignored correctly.

If you are running 1.1.1, can you upgrade and let me know if you are still having problems? If it still isn't working, some sort of repro case code would do wonders for helping us debug this further. Thanks!

@rodrigok
Copy link
Author

Hi, yes, I was running the 1.1.1 version.

I updated the package to 1.2.0 and seems that the 401 and 403 codes were ignored by newrelic.

But, I still receiving reports of /ping url that is not necessary for me.

Thanks.

@rodrigok
Copy link
Author

Sorry, I'm still receiving errors 401 and 403.

There are some way to see configuration loaded by application in the newrelic website?

@groundwater
Copy link
Contributor

Hi @rodrigok, I have also confirmed your results, but have not identified the cause yet. I am unfortunately traveling at the moment, and may not get a chance to until Monday.

A well placed console.log shows that /ping does indeed get picked up by config, but perhaps it is not getting there in time, or there is something else going on.

Can you email us ([email protected], [email protected]) with a link to your account.

Thanks for taking the time to help troubleshoot this with us.

@rodrigok
Copy link
Author

Of course, I will send you an email asap.

Thank you by your support.

I want to suggest to include de hability to review configuration loaded by application in somewhere inside newrelic webseite.

[]'s

@imkira
Copy link

imkira commented Mar 19, 2014

I have just received a reply from support after also reporting this bug and the answer I got was:

Thank you for writing in. Currently within the New Relic Node.js agent error ignoring will need to be handled using ignore_status_codes. At this time the functionality to configure this server side is not available (though the option does appear under the application settings in the UI).

We apologize for any confusion this may have caused. When configured using ignore_status_codes are the errors being ignored as expected? Please let us know.

@othiym23
Copy link
Contributor

The server-side configuration piece of this will be fixed in one of the next couple releases of the module. I'm not sure it's the same problem that @rodrigok was looking to have addressed, though.

@robbiet480
Copy link

I started having this problem too. Good to hear it will be fixed soon!

@imkira
Copy link

imkira commented Mar 30, 2014

@othiym23 btw, this may be a little off topic but would it be possible to ignore errors not based on http error codes but according to some predicate. Say I have some 400-type errors I would like to ignore and others I would like to keep track of. I assume newrelic.setIgnoreTransaction achieves this but it also seems to ignore all metrics associated with the transaction. So, in sum, I want to keep some types of errors from getting reported as errors and affecting my error statistics but still get all those transaction metrics. Is this even possible?

@othiym23
Copy link
Contributor

Some of the other instrumentation packages allow you to either ignore just the apdex metrics or the errors related to a transaction, so the concept definitely exists. However, it requires making some pervasive changes to the error and transaction tracers, so it would have to be treated as an actual feature addition rather than something that can be added over an afternoon (touching anything that gets close to the tracers makes me nervous).

As always, the best way to get this added is to send a request to [email protected], so we can get this feature onto the product roadmap. No promises on when we might get to it!

@zoheb
Copy link

zoheb commented May 29, 2014

Any updates on when this will be fixed? I am having the same issue, I have added

 error_collector: {
        ignore_status_code: [403,401]
  }

to my config.js, but it's still capturing 401 and 403 errors.

@wraithan
Copy link
Contributor

@zohebsait to be clear, error_collector.ignore_status_code only applies for incoming requests, not outgoing requests. If you are having issues with requests coming to your server, where you return 401, and we are still collecting it, then you should contact support so we can get some more data from you http://support.newrelic.com/

If you are doing external calls to services and they are returning 401, we don't have any setup for ignoring that sort of error. there is a feature request for it but it hasn't been implemented it.

@zoheb
Copy link

zoheb commented May 29, 2014

Ah, thanks for clarifying that. I am infact proxying the request to a external service and it's returning 401. I was trying to get newrelic to ignore these.

Is there an estimate on when the feature to ignore these errors would be implemented?

@wraithan
Copy link
Contributor

@zohebsait It is in the feature request queue and our product manager knows about it. We take the requests seriously but can't really give an estimate of when it will be implemented. It is something I'd like to spend time on though so I hope it isn't too far in the future.

@zoheb
Copy link

zoheb commented May 29, 2014

@wraithan - thanks! will keep an eye out for this in the near future releases!

@txase txase added the bug label Jun 26, 2014
@wesrog wesrog closed this as completed Jun 10, 2019
cmcadams-newrelic pushed a commit to cmcadams-newrelic/node-newrelic that referenced this issue Jan 29, 2024
…logs-in-context/app/protobufjs-7.2.4

chore(deps): bump protobufjs from 7.2.3 to 7.2.4 in /logs-in-context/app
jsumners-nr pushed a commit to jsumners-nr/node-newrelic that referenced this issue Apr 11, 2024
jsumners-nr pushed a commit to jsumners-nr/node-newrelic that referenced this issue Apr 16, 2024
bizob2828 pushed a commit to bizob2828/node-newrelic that referenced this issue Apr 19, 2024
bizob2828 pushed a commit to bizob2828/node-newrelic that referenced this issue Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

10 participants