chore: Fixed comment about transaction_tracer.transaction_threshold #2258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a comment in our configuration defaults. Basically, the comment had the intention inverted. The best documentation I could find to verify the configuration setting in general is in the Java agent's code -- https://github.com/newrelic/newrelic-java-agent/blob/a4187358aeeda79d9b9d0b7ca87faf378bd35d82/newrelic-agent/src/main/resources/newrelic.yml#L195-L213. This meshes with our actual implementation:
node-newrelic/lib/transaction/trace/aggregator.js
Lines 231 to 292 in 46924e5
The Python agent's documentation concurs -- https://docs.newrelic.com/docs/apm/agents/python-agent/configuration/python-agent-configuration/#txn-tracer-threshold