Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Removed tap and cleaned up left over tap helpers #2804

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

bizob2828
Copy link
Member

Description

Removed tap, tap assertions and any references to tap. Lastly, I cleaned up a unit test that was slow and had some hacks applied around timers. This will fail until we migrate apollo-server versioned tests

Related Issues

Closes #2799

@bizob2828 bizob2828 added the dev:tests Indicates only changes to tests label Nov 26, 2024
jsumners-nr
jsumners-nr previously approved these changes Nov 26, 2024
@bizob2828 bizob2828 requested a review from jsumners-nr December 9, 2024 21:04
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.16%. Comparing base (64d2042) to head (2a09ce8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2804       +/-   ##
===========================================
+ Coverage   79.18%   97.16%   +17.97%     
===========================================
  Files         284      294       +10     
  Lines       45236    46403     +1167     
===========================================
+ Hits        35820    45087     +9267     
+ Misses       9416     1316     -8100     
Flag Coverage Δ
integration-tests-cjs-18.x 73.29% <ø> (?)
integration-tests-cjs-20.x 73.30% <ø> (?)
integration-tests-cjs-22.x 73.33% <ø> (?)
unit-tests-18.x 88.96% <ø> (?)
unit-tests-20.x 88.96% <ø> (?)
unit-tests-22.x 88.96% <ø> (?)
versioned-tests-18.x 78.98% <ø> (?)
versioned-tests-20.x 78.99% <ø> (-0.20%) ⬇️
versioned-tests-22.x 79.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jsumners-nr
jsumners-nr previously approved these changes Dec 10, 2024
@bizob2828 bizob2828 merged commit 37407b6 into newrelic:main Dec 10, 2024
26 checks passed
@bizob2828 bizob2828 deleted the remove-tap branch December 10, 2024 14:15
@github-actions github-actions bot mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:tests Indicates only changes to tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Tap cleanup
2 participants