Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added New Relic Control health check #2841

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jsumners-nr
Copy link
Contributor

This PR resolves #2838.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 52.32975% with 133 lines in your changes missing coverage. Please review.

Project coverage is 79.03%. Comparing base (a93fe6e) to head (79b116c).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
lib/health-reporter.js 48.57% 108 Missing ⚠️
lib/agent.js 10.71% 25 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (a93fe6e) and HEAD (79b116c). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (a93fe6e) HEAD (79b116c)
integration-tests-cjs-20.x 1 0
unit-tests-22.x 1 0
integration-tests-esm-18.x 1 0
unit-tests-18.x 1 0
integration-tests-cjs-22.x 1 0
unit-tests-20.x 1 0
integration-tests-cjs-18.x 2 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2841       +/-   ##
===========================================
- Coverage   97.27%   79.03%   -18.24%     
===========================================
  Files         296      287        -9     
  Lines       46560    45664      -896     
===========================================
- Hits        45289    36092     -9197     
- Misses       1271     9572     +8301     
Flag Coverage Δ
integration-tests-cjs-18.x ?
integration-tests-cjs-20.x ?
integration-tests-cjs-22.x ?
integration-tests-esm-18.x ?
integration-tests-esm-20.x 49.92% <52.32%> (+0.03%) ⬆️
integration-tests-esm-22.x 49.97% <52.32%> (+0.03%) ⬆️
unit-tests-18.x ?
unit-tests-20.x ?
unit-tests-22.x ?
versioned-tests-18.x 78.94% <52.32%> (-0.33%) ⬇️
versioned-tests-20.x 78.95% <52.32%> (-0.33%) ⬇️
versioned-tests-22.x 78.95% <52.32%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know this is in draft, just called out the lack of config items defined

lib/health-reporter.js Outdated Show resolved Hide resolved
@jsumners-nr jsumners-nr force-pushed the issue-2838 branch 2 times, most recently from 9ad5af4 to 79b116c Compare January 13, 2025 17:21
@jsumners-nr jsumners-nr marked this pull request as ready for review January 13, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs PR Review
Development

Successfully merging this pull request may close these issues.

[Spike] Super Agent Health Check
2 participants