Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added instrumentation for @opensearch-projects/opensearch v2.1.0+ #2850

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

bizob2828
Copy link
Member

Description

Adds instrumentation for @opensearch-projects/opensearch 2.1.0+. It turns out at this time the interface is exactly the same as elasticsearch. I copied the instrumentation but could abstract if need be.

How to Test

npm run versioned:internal opensearch

Related Issues

Closes #2849

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 93.25153% with 11 lines in your changes missing coverage. Please review.

Project coverage is 97.20%. Comparing base (8820265) to head (f8488cf).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../instrumentation/@opensearch-project/opensearch.js 93.16% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2850      +/-   ##
==========================================
- Coverage   97.26%   97.20%   -0.07%     
==========================================
  Files         295      296       +1     
  Lines       46462    46625     +163     
==========================================
+ Hits        45191    45321     +130     
- Misses       1271     1304      +33     
Flag Coverage Δ
integration-tests-cjs-18.x 73.14% <100.00%> (+<0.01%) ⬆️
integration-tests-cjs-20.x 73.15% <100.00%> (+<0.01%) ⬆️
integration-tests-cjs-22.x 73.18% <100.00%> (+<0.01%) ⬆️
integration-tests-esm-18.x 49.92% <100.00%> (+<0.01%) ⬆️
integration-tests-esm-20.x 49.93% <100.00%> (+<0.01%) ⬆️
integration-tests-esm-22.x 49.98% <100.00%> (+<0.01%) ⬆️
unit-tests-18.x 88.92% <100.00%> (+<0.01%) ⬆️
unit-tests-20.x 88.92% <100.00%> (+<0.01%) ⬆️
unit-tests-22.x 88.92% <100.00%> (+<0.01%) ⬆️
versioned-tests-18.x 79.09% <93.25%> (-0.12%) ⬇️
versioned-tests-20.x 79.07% <93.25%> (-0.15%) ⬇️
versioned-tests-22.x 79.10% <93.25%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mrickard
mrickard previously approved these changes Dec 19, 2024
@bizob2828 bizob2828 merged commit 763c0e6 into newrelic:main Jan 2, 2025
22 of 25 checks passed
@bizob2828 bizob2828 deleted the add-opensearch branch January 2, 2025 16:21
@github-actions github-actions bot mentioned this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

opensearch instrumentation support
2 participants