-
Notifications
You must be signed in to change notification settings - Fork 47
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update how histogram&summary metrics are reported
As New Relic is improving its support for Prometheus native format, we could change the way how we report Summary and Histogram metric types and do it in less disruptive way, meaning that we send them as they come from Prometheus, without adding custom suffixes or calculating percentiles from the integration side. These are the details of the current implementation: - xxx_bucket is ingested as a Counter (converted to a delta rather than accumulative). Metrics containing dimension "le" == '+Inf' are also sent, we don't omit them. - xxx_count is passed through as a Counter (converted to a delta rather than accumulative). - xxx_total passed through as a Counter (converted to a delta rather than accumulative). - xxx_sum is passed through as a NR Summary converted to a delta rather than accumulative, Min and Max here should be NaN. Its value can be negative. The count field of the summary should be 1. - For Prometheus summary metrics, we report the quantile as a dimension and we don't add a "percentile" dimension.
- Loading branch information
Toni Reina
committed
Jun 19, 2020
1 parent
276f7cf
commit 0250ae2
Showing
8 changed files
with
103 additions
and
422 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.