Hide license key in logs #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorgan3
previously approved these changes
Oct 18, 2019
internal/integration/fetcher.go
Outdated
| @@ -279,7 +279,7 @@ const ( | |||
| metricType_GAUGE metricType = "gauge" | |||
| metricType_SUMMARY metricType = "summary" | |||
| metricType_HISTOGRAM metricType = "histogram" | |||
| metricType_UNTYPED metricType = "untyped" | |||
| //metricType_UNTYPED metricType = "untyped" | |||
There was a problem hiding this comment.
Yep, it's an unused variable, the code won't compile with it on my machine. I'll just remove it instead of commenting it out
jorik
force-pushed
the
feature/hide-license-key-in-logs
branch
from
90a2131 to
775c74d
Compare
lorgan3
previously approved these changes
Oct 18, 2019
jorik
force-pushed
the
feature/hide-license-key-in-logs
branch
from
01e5227 to
829fb3c
Compare
alejandrodnm
approved these changes
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.