-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update project to use go modules #49
Conversation
Snyk is failing in the CI |
We are setting the |
@alejandrodnm I retriggered the build and and it failed the same way. 🤔 |
@douglascamata I told @areina that I will look at this, it seems to be a problem I'll try with a different service account. |
Here you have the reason why the build is failing: https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions We should find another way of integrating the project with snyk. Did we consider using the Snyk's GH integration instead of calling snyk test from travis? |
@areina The snyk docs say that they only support go modules via the snyk CLI https://support.snyk.io/hc/en-us/articles/360003817417-Snyk-for-Golang |
@areina I'll ask snyk support but I think we will have to disable snyk for PRs where the env var is not set, at least this way when the PR is merged the merged job will run and snyk will run. |
@alejandrodnm while you get an answer from Snyk, I've created a new PR #51 skipping |
In the past wasn't possible to use go modules because it didn't work well with k8s client-go library. However, there is already good support for it in newer versions of that library and this project seems to work well with modules.