Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project to use go modules #49

Merged
merged 5 commits into from
Jun 9, 2020
Merged

Conversation

areina
Copy link
Contributor

@areina areina commented Jun 5, 2020

In the past wasn't possible to use go modules because it didn't work well with k8s client-go library. However, there is already good support for it in newer versions of that library and this project seems to work well with modules.

alejandrodnm
alejandrodnm previously approved these changes Jun 7, 2020
@alejandrodnm
Copy link
Contributor

Snyk is failing in the CI

@alejandrodnm
Copy link
Contributor

We are setting the SNYK_TOKEN and the service account is still valid, can you trigger the CI again?

@areina areina closed this Jun 8, 2020
@areina areina reopened this Jun 8, 2020
@douglascamata
Copy link

@alejandrodnm I retriggered the build and and it failed the same way. 🤔

@alejandrodnm
Copy link
Contributor

alejandrodnm commented Jun 8, 2020

@douglascamata I told @areina that I will look at this, it seems to be a problem I'll try with a different service account.

@areina
Copy link
Contributor Author

areina commented Jun 8, 2020

Here you have the reason why the build is failing: https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions

We should find another way of integrating the project with snyk. Did we consider using the Snyk's GH integration instead of calling snyk test from travis?

@alejandrodnm
Copy link
Contributor

@areina The snyk docs say that they only support go modules via the snyk CLI https://support.snyk.io/hc/en-us/articles/360003817417-Snyk-for-Golang

@alejandrodnm
Copy link
Contributor

@areina I'll ask snyk support but I think we will have to disable snyk for PRs where the env var is not set, at least this way when the PR is merged the merged job will run and snyk will run.

@areina
Copy link
Contributor Author

areina commented Jun 9, 2020

@alejandrodnm while you get an answer from Snyk, I've created a new PR #51 skipping snyk test on PR builds. If they provide another solution, we could get back the current approach.

@alejandrodnm alejandrodnm reopened this Jun 9, 2020
@alejandrodnm alejandrodnm merged commit 46b4310 into newrelic:master Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants