Immutable newrelic_entity_tags are not filtered anymore

[b-viguier]

Hello 👋 😃

Since 2.24.1, immutable newrelic_entity_tags are not filtered, it means that immutable tags like monitorStatus or monitorType are listed for deletion by the provider (fortunately, it's not possible to delete them).
It has already been reported in #766 and fixed in newrelic/newrelic-client-go#462 : the ListTags function calls a new function filterMutable.

But recently, ListTags has been deprecated and replaced by GetTagsForEntity (see https://github.com/newrelic/terraform-provider-newrelic/pull/1347/files#diff-e2ac9cf2bc502dba7eddd8043ab326231737f12dc963bdbc5f24b170b8b4b561 ). This function doesn't call filterMutable, then built-in NewRelic tags are listed for modification 😕

Thanks for your work 🙇‍♂️

[stale]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs.

[stale]

This issue has been automatically closed due to a lack of activity for an extended period of time.

[joshuaakelly]

This issue is still occuring in v2.25

[kidk]

Thanks for report @joshuaakelly and @b-viguier

We'll take a look.

[b-viguier]

Thanks! 🙇