Implement TagsWithMetadata to avoid non-modifiable result sets #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, all tags are included in the list operation which leads to user surprise when modifications are attempted. Here we modify the method response to exclude those tags which are not modifiable by the user.
zlesnr
force-pushed
the
entityTagMeta
branch
from
fbc3c24 to
373ee15
Compare
sanderblue
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to newrelic/terraform-provider-newrelic#756, newrelic/terraform-provider-newrelic#791 and newrelic/terraform-provider-newrelic#766
The nerdgraph schema has been updated to include the information about a users chances of modifying a given entity tag. Here we hide those which are not user-editable from the user.