Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More feature work #117

Merged
merged 4 commits into from
Dec 4, 2020
Merged

More feature work #117

merged 4 commits into from
Dec 4, 2020

Conversation

jthurman42
Copy link
Contributor

@jthurman42 jthurman42 commented Dec 3, 2020

Working to make the code generation smoother.

@jthurman42 jthurman42 self-assigned this Dec 3, 2020
@jthurman42 jthurman42 added this to the GraphQL Dashboards API milestone Dec 3, 2020
@jthurman42 jthurman42 added enhancement New feature or request priority:medium Triaged as a medium size:M Medium labels Dec 3, 2020
@jthurman42 jthurman42 marked this pull request as ready for review December 4, 2020 17:15
@jthurman42 jthurman42 requested a review from a team December 4, 2020 17:15
@@ -344,7 +344,7 @@ func (s *Schema) GetQueryStringForEndpoint(typePath []*Type, fieldPath []string,

// Append to QueryArgs and EndpointArgs only after the parent field
// requirements have been added so that they are last.
args := s.BuildQueryArgsForEndpoint(t, []string{endpoint}, false)
args := s.BuildQueryArgsForEndpoint(t, []string{endpoint}, includeNullable)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jthurman42 jthurman42 merged commit 24d5b1a into master Dec 4, 2020
@jthurman42 jthurman42 deleted the jthurman/dedupe branch December 4, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:medium Triaged as a medium size:M Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants