Give a more succinct error message when user specifies nonexistent files #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we get a whole backtrace which is alarming Signed-off-by: Ell Bradshaw <[email protected]>
cincodenada
force-pushed
the
nicer-file-error
branch
from
86586f1 to
12d7914
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently specifying nonexistent files to options gives a whole Python backtrace, with the filename output in
b'filename'bytestring notation which is even more confusing.There are plenty of approaches here, this just catches any FileNotFoundErrors and raises a more succinct error message about it, which doesn't tell you which is the offending argument, but that should be apparent enough, and in any case, this seems to me like strictly an improvement over the backtrace that currently happens.