fix: downgrades [email protected] -> [email protected] to make storybook-native stop crashing #650
+23
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please find visual snapshots of your changed components here: https://s3-eu-west-1.amazonaws.com/times-components-snaps/a4cc341ce24f5f105fef8abc8f1f72e4e8c1b595/dextrose-test/index.html |
|
it fixed the issue with the refresh but unfortunately the issue with the ios simulator (and no stories) remains. |
nikhedonia
changed the title
nikhedonia
force-pushed
the
fix/storybook-native
branch
from
a4cc341 to
0d4f369
Compare
|
already merged into fix/storybook-ios |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes the storybook-native bug on OSX that crashes storybook (webpack-dev-server) if you reload the page.
related issues:
storybookjs/storybook#2923
websockets/ws#1256