-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: storybook-native ios issue #658
Conversation
Please find visual snapshots of your changed components here: https://s3-eu-west-1.amazonaws.com/times-components-snaps/3be064599a99d8518138ef4e7bcefb8337c7281f/dextrose-test/index.html |
We are almost there! We need to lockdown the react native version otherwise we'll might get this issue: After running:
I get: EDIT: Unfortunately, adding a specific version of react native didn't resolve this issue for me. Locking it down to 0.52.0 gives me the following error: Locking it down to 0.50.1 leads to: Did you modify your yarn.lock ? |
@nikhedonia no, I didn't. Could be related to some missed update of the Xcode SDK maybe? |
603f0d4
to
2259489
Compare
2259489
to
6df6291
Compare
Please find visual snapshots of your changed components here: https://s3-eu-west-1.amazonaws.com/times-components-snaps/6df629174ce5d5817ed9cb0f394efb7ac9b8fe34/dextrose-test/index.html |
as a side note, doesn't fix: facebook/react-native#6627 |
Update the storybook-native ios with the latest changes related to react-native 0.50.1