Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: storybook-native ios issue #658

Merged
merged 3 commits into from
Feb 16, 2018
Merged

fix: storybook-native ios issue #658

merged 3 commits into from
Feb 16, 2018

Conversation

a-ursino
Copy link
Contributor

@a-ursino a-ursino commented Feb 15, 2018

Update the storybook-native ios with the latest changes related to react-native 0.50.1

@times-tools
Copy link
Collaborator

@nikhedonia
Copy link
Contributor

nikhedonia commented Feb 15, 2018

We are almost there! We need to lockdown the react native version otherwise we'll might get this issue:

After running:

git clean -xdf
yarn install
yarn ios

I get:

screen shot 2018-02-15 at 18 37 39

EDIT:

Unfortunately, adding a specific version of react native didn't resolve this issue for me.

Locking it down to 0.52.0 gives me the following error:

screen shot 2018-02-15 at 18 47 39

Locking it down to 0.50.1 leads to:

screen shot 2018-02-15 at 18 54 51

Did you modify your yarn.lock ?

@a-ursino
Copy link
Contributor Author

@nikhedonia no, I didn't. Could be related to some missed update of the Xcode SDK maybe?

@nikhedonia nikhedonia force-pushed the fix/storybook-ios branch 2 times, most recently from 603f0d4 to 2259489 Compare February 16, 2018 11:49
@times-tools
Copy link
Collaborator

@nikhedonia
Copy link
Contributor

as a side note, doesn't fix: facebook/react-native#6627

@nikhedonia nikhedonia self-requested a review February 16, 2018 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants