Manual Rotator button no longer works with 4.0

[ghilios]

After upgrading the firmware to 4.0.0, the manual rotation button on the physical device no longer works. ASCOM control still functions though.

[AstroFrank]

Yes, I just upgraded to 4.0. I also have the same issue. The manual rotation button no longer work.

…

On Sun., Mar. 7, 2021, 7:38 p.m. George Hilios, ***@***.***> wrote: After upgrading the firmware to 4.0.0, the manual rotation button on the physical device no longer works. ASCOM control still functions though. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#38>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AASUAAENMZERA4PIGXO5JK3TCQMABANCNFSM4YYN6OQQ> .

[NameOfTheDragon]

Thanks for reporting. I have had independent confirmation of the issue - it seems like it might be a timeout that may be related to the holding torque changes that went into the latest release. It's under investigation.

[NameOfTheDragon]

Here is the offending code:

		// Release stepper holding torque if there has been no serial communication for "a long time".
		if (serialInactivityTimer.Expired())
			stepper.releaseMotor();

This runs in the main loop and once the timer has expired it will keep disabling the stepper motor every time around the loop. Any activity on the serial port resets the timer, which is why the ASCOM driver (et al) still work. It should be a simple fix.

[ghilios]

Nice! Let me know if you'd like me to test it before you release.

[NameOfTheDragon]

@ghilios @AstroFrank Please could you try the hex file attached to this pull request and let me know if it solves the problem?
#39

[NameOfTheDragon]

Yes please, I attached a hex file to the PR #39/#issuecomment-794570409 --T.

…

________________________________ From: George Hilios <[email protected]> Sent: 09 March 2021 22:24 To: nexdome/Firmware <[email protected]> Cc: Tim Long <[email protected]>; Comment <[email protected]> Subject: Re: [nexdome/Firmware] Manual Rotator button no longer works with 4.0 (#38) Nice! Let me know if you'd like me to test it before you release. — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#38 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAJVWCUAC7XVCRPMHOHPR7LTC2GXFANCNFSM4YYN6OQQ>.

[AstroFrank]

Hello Tim, I loaded the 4.0.1 rotator fw without any problem. Just after the update, without connecting any ASCOM client, the holding torque was off, I pushed the manual rotator switch in both directions, and that functioned correctly. The holding torque was on just after I pressed the manual buttons. The bug is fixed as far as I can tell. Thank you.

…

On Tue., Mar. 9, 2021, 5:58 p.m. Tim Long, ***@***.***> wrote: @ghilios <https://github.com/ghilios> @AstroFrank <https://github.com/AstroFrank> Please could you try the hex file attached to this pull request and let me know if it solves the problem? #39 <#39> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#38 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AASUAAE22RM4KA3SNPCPEW3TC2RZ3ANCNFSM4YYN6OQQ> .

[ghilios]

Sorry I was ill yesterday and couldn't get to it. I will try today after work!

[NameOfTheDragon]

Thanks George, don't stress over it. My own tests suggest that the fix is good and I've had another independent confirmation. I'm going to issue a bugfix release later today.

…

--T.

________________________________ From: George Hilios ***@***.***> Sent: 11 March 2021 13:18 To: nexdome/Firmware ***@***.***> Cc: Tim Long ***@***.***>; Comment ***@***.***> Subject: Re: [nexdome/Firmware] Manual Rotator button no longer works with 4.0 (#38) Sorry I was ill yesterday and couldn't get to it. I will try today after work! — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#38 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAJVWCUICFZG63G3QMVN2TDTDCYKHANCNFSM4YYN6OQQ>.