[KYUUBI #6204] Fix kyuubi session limiter leak when opening session f… #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion f… …ailed # 🔍 Description ## Issue References 🔗 This pull request fixes # ## Describe Your Solution 🔧 We found that, a user has no active sessions, but kyuubi said that the user reach the max limit sessions per user. Now, we increase the session limiter for user when opening session and decrease it when closing session. But if the user open session failed, it will not decrease the session limiter. This pr fix session limiter leak issue when failed to open session. Before open session, add session handle into sessionHandleMap, and invoke SessionManager::closeSession when failed to open session. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6204 from turboFei/limiter_leak. Closes apache#6204 c0f2969 [Wang, Fei] refine 98fda94 [Wang, Fei] fix leak Authored-by: Wang, Fei <[email protected]> Signed-off-by: Wang, Fei <[email protected]>
minyk
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ailed
🔍 Description
Issue References 🔗
This pull request fixes #
Describe Your Solution 🔧
We found that, a user has no active sessions, but kyuubi said that the user reach the max limit sessions per user. Now, we increase the session limiter for user when opening session and decrease it when closing session.
But if the user open session failed, it will not decrease the session limiter.
This pr fix session limiter leak issue when failed to open session.
Before open session, add session handle into sessionHandleMap, and invoke SessionManager::closeSession when failed to open session.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.
Closes apache#6204 from turboFei/limiter_leak.
Closes apache#6204
c0f2969 [Wang, Fei] refine
98fda94 [Wang, Fei] fix leak
Authored-by: Wang, Fei [email protected]
🔍 Description
Issue References 🔗
This pull request fixes #
Describe Your Solution 🔧
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.