Require detector_db in all cities

[jwaiton]

As discussed in issue #850, the default city decorator provides detector_db = 'new' to each city if none is provided. This causes some issues (particularly with Beersheba) and so has been removed.

In doing so, multiple cities now require detector_db to be within their config files to pass tests, and indexation_test.py has been modified to account for this change in city signature.

Closes #850

[gonzaponte]

Looks good. The only test failing is known to fail and has nothing to do with this. I would like to have a test that verifies that all cities indeed require this argument and there is nothing else messing around.

[jwaiton]

I've developed the test within db_test.py, I believe it works as intended (tested different cases and got the expected results), but it's my first time developing python tests so I could have made some errors that I'm unaware of.

This test can easily be included in the cities_test.py file, which I'll do after I've finalised the test wrt any feedback you have.

[jwaiton]

More tests are now failing on github which didn't fail locally, although I'm not entirely sure why. They all seem to be related to an attribute error:
AttributeError: 'function' object has no attribute 'send'

Rerunning these tests locally do not produce the same errors, it may be something to do with how I defined the relative import paths, but I'm not entirely sure.

[gonzaponte]

I don't quite understand the error either, I will have to look at it more interactively. But this error wasn't there before the last commit, right?

[jwaiton]

I don't quite understand the error either, I will have to look at it more interactively. But this error wasn't there before the last commit, right?

You're correct, the error wasn't present before this commit.

[gonzaponte]

it may be something to do with how I defined the relative import paths, but I'm not entirely sure.

Change
from invisible_cities.core.configure import configure
to
from .. core.configure import configure

[jwaiton]

I've added the regexp to the test as well as the required changes and it seems to work as expected locally. Hopefully the same is true on github :)

[gonzaponte]

Hmm. Tests pass locally for me as well... This is bizarre.

[gonzaponte]

I think this is the last of it. If the checks pass we will rewrite the commit history a bit and merge.

[jwaiton]

That should be it, hopefully it passes all the tests :)

[gonzaponte]

The history has been cleaned up with peras.

[gonzaponte]

A necessary improvement towards NEXT100: not assuming a detector configuration. Great work.

[carhc]

Just merged! Thanks @jwaiton for your first contribution to IC! Looking forward to seeing more of your nice work!